Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid

From: Finn Thain
Date: Thu Mar 03 2022 - 03:35:52 EST



On Wed, 2 Mar 2022, Tom Rix wrote:

> >>> Long term, it would be good have a reliable way to automatically fix
> >>> either new files or really broken old files.
> >> That's really a maintainer preference no?
> >>
> >> Especially so for any automation.
> >
> > In practice everything is up to the maintainer.
> >
> > If some maintainer wants fix their formatting then clang-format should
> > just work
> >
> > It isn't likely they will have time to hand fix every file.
>
> A follow up issue in the clang project has been raised by Konrad, here
>
> https://github.com/llvm/llvm-project/issues/54137
>

Why request a "leave" option for every style rule? Why not just a "leave"
option for the most contentious rules?

The response from the developers that anyone who wants to leave existing
code unmolested by certain rules should "wake up and smell the coffee" is
obnoxious, IMO.

Presumably clang-format must grow until it has sufficient program logic
and config options to cater to every exception to every rule. How long
will that take? Some carefully chosen "leave" options might make the
program much more useful in the near term.

> Tom
>
>
> >
> > Tom
> >
> >>
> >>
>