Re: [Patch v4 1/4] arm64: tegra: Add memory controller channels

From: Krzysztof Kozlowski
Date: Wed Mar 02 2022 - 14:33:02 EST


On 02/03/2022 09:43, Ashish Mhetre wrote:
> From tegra186 onwards, memory controller support multiple channels.
> During the error interrupts from memory controller, corresponding
> channels need to be accessed for logging error info and clearing the
> interrupt.
> So add address and size of these channels in device tree node of
> tegra186, tegra194 and tegra234 memory controller.
>
> Signed-off-by: Ashish Mhetre <amhetre@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/nvidia/tegra186.dtsi | 7 ++++++-
> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 21 ++++++++++++++++++---
> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 21 ++++++++++++++++++---
> 3 files changed, 42 insertions(+), 7 deletions(-)
>

You send DTS patch before, which is wrong order and actually it points
my attention to probably ABI break.

DTS goes always separately from driver changes so it is not only ABI
break, but also non-bisectable.

Best regards,
Krzysztof