Re: [PATCH v1 1/3] auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature

From: Andy Shevchenko
Date: Wed Mar 02 2022 - 10:48:02 EST


On Wed, Feb 23, 2022 at 05:47:16PM +0200, Andy Shevchenko wrote:
> It seems that the lcd2s_redefine_char() has never been properly
> tested. The buffer is filled by DEF_CUSTOM_CHAR command followed
> by the character number (from 0 to 7), but immediately after that
> these bytes are got rewritten by the decoded hex stream.
>
> Fix the index to fill the buffer after the command and number.

Any comments on this, please? There are fixes and seems auxdisplay subsystem
is a bit lagging... Should we worry about?

--
With Best Regards,
Andy Shevchenko