Re: 回复:[PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq_byname()

From: Mark Brown
Date: Wed Mar 02 2022 - 08:11:58 EST


On Wed, Mar 02, 2022 at 09:17:21AM +0800, Yang.Lee wrote:

Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> The function dev_err_probe() is called in function platform_get_irq_byname() to print the error code.

That doesn't seem at all relevant to the error code being returned which
is what the review feedback was about:

> > If an error code is being returned we should report that error code
> > rather than squashing it down to -ENODEV.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.

Attachment: signature.asc
Description: PGP signature