Re: [PATCH] ALSA: intel_hdmi: Fix reference to PCM buffer address

From: Takashi Iwai
Date: Wed Mar 02 2022 - 03:27:53 EST


On Wed, 02 Mar 2022 08:42:41 +0100,
Zhen Ni wrote:
>
> PCM buffers might be allocated dynamically when the buffer
> preallocation failed or a larger buffer is requested, and it's not
> guaranteed that substream->dma_buffer points to the actually used
> buffer. The driver needs to refer to substream->runtime->dma_addr
> instead for the buffer address.
>
> Signed-off-by: Zhen Ni <nizhen@xxxxxxxxxxxxx>

Thanks, applied now with Cc-to-stable.

I guess the had_pcm_mmap() can be dropped completely and replaced with
the standard mmap helper, as what we really want is rather wc.
But it can be done for 5.18.


Takashi