Re: propagating vmgenid outward and upward

From: Jason A. Donenfeld
Date: Tue Mar 01 2022 - 13:24:35 EST


Hi Greg,

On Tue, Mar 1, 2022 at 7:01 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> A notifier block like this makes sense, but why tie onto the PM_ stuff?
> This isn't power management issues, it's a system-wide change that I am
> sure others will want to know about that doesn't reflect any power
> changes.
>
> As much as I hate adding new notifiers in the kernel, that might be all
> you need here.

You might indeed be right. I guess I was thinking that "resuming from
suspend" and "resuming from a VM fork" are kind of the same thing.
There _is_ a certain kind of similarity between the two. I was hoping
if the similarity was a strong enough one, maybe it'd make sense to do
them together rather than adding another notifier. But I suppose you
disagree, and it sounds like Rafael might too --
<https://lore.kernel.org/lkml/CAJZ5v0g+GihH_b9YvwuHzdrUVNGXOeabOznDC1vK6qLi8gtSTQ@xxxxxxxxxxxxxx/>.
Code-wise for me with WireGuard it's of course appealing to treat them
the same, since it's like a one line change, but if I need to add a
new notifier call there, it's not the end of the world.

Jason