Re: [PATCH] KVM: x86/mmu: Passing up the error state of mmu_alloc_shadow_roots()

From: Sean Christopherson
Date: Tue Mar 01 2022 - 10:47:38 EST


On Tue, Mar 01, 2022, Like Xu wrote:
> From: Like Xu <likexu@xxxxxxxxxxx>
>
> Just like on the optional mmu_alloc_direct_roots() path, once shadow
> path reaches "r = -EIO" somewhere, the caller needs to know the actual
> state in order to enter error handling and avoid something worse.

Well that's emabarrassing.

> Fixes: 4a38162ee9f1 ("KVM: MMU: load PDPTRs outside mmu_lock")

Cc: stable@xxxxxxxxxxxxxxx

> Signed-off-by: Like Xu <likexu@xxxxxxxxxxx>
> ---

Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx>