Re: [PATCH V6 1/3] PCI/ASPM: Add pci_enable_default_link_state()

From: Christoph Hellwig
Date: Tue Mar 01 2022 - 08:38:34 EST


On Tue, Mar 01, 2022 at 05:31:51AM -0800, David E. Box wrote:
> > Is there any reason the ASPM_* values aren't passed directly to this
> > function?
>
> The ASPM_* macors aren't visible outside of aspm.c whereas the
> PCIE_LINK_STATE_* macros are defined in pci.h. This is similar to what
> is done for pci_disable_link_state().

Ok. This looks a little weird but I guess we should stick to the
existing pattern here.