Re: [PATCH] dt-bindings: phy: renesas,usb2-phy: Document RZ/V2L phy bindings

[Lad, Prabhakar]

Hi Geert and Shimoda-san,

Thank you for the review.

On Mon, Feb 28, 2022 at 2:35 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> On Mon, Feb 28, 2022 at 3:18 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > > From: Lad Prabhakar, Sent: Monday, February 28, 2022 8:08 AM
> > >
> > > Document USB phy bindings for RZ/V2L SoC. RZ/V2L USB phy is identical to
> > > one found on the RZ/G2L SoC. No driver changes are required as generic
> > > compatible string "renesas,rzg2l-usb2-phy" will be used as a fallback.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > ---
> > >  Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > index 3a6e1165419c..4c475be413ef 100644
> > > --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > > @@ -33,6 +33,7 @@ properties:
> > >        - items:
> > >            - enum:
> > >                - renesas,usb2-phy-r9a07g044 # RZ/G2{L,LC}
> > > +              - renesas,usb2-phy-r9a07g054 # RZ/V2L
> > >            - const: renesas,rzg2l-usb2-phy  # RZ/G2L family
> >
> > The "# RZ/G2L family" is not suitable now. I think removing
> > the comment is better like "renesas,rcar-gen3-usb2-phy".
>
> Indeed.
>
Agreed, I will drop it and resend a v2.

Cheers,
Prabhakar

> > I don't have the RZ/V2L- documentation. So, I cannot check
> > whether the RZ/V2L is the same specification with RZ/G2{L,LC}.
> > But I trust you. So, after the comment was removed,
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds