Re: [PATCH 1/3] crypto: sm4 - create SM4 library based on sm4 generic code

From: Jason A. Donenfeld
Date: Tue Mar 01 2022 - 05:34:46 EST


> lib/crypto/Kconfig | 3 +
> lib/crypto/Makefile | 3 +
> lib/crypto/sm4.c | 184 +++++++++++++++++++++++++++++++++++++++++++

If this is only used by the crypto API, it does not belong in
lib/crypto. I understand you want fallback generic code for the SIMD
implementation, but we've generally done that in crypto/ when the use
case is only the crypto API. Can you move this to the right place?