Re: [PATCH v3 8/9] i2c: piix4: Add EFCH MMIO support for SMBus port select

From: Terry Bowman
Date: Fri Jan 21 2022 - 16:02:13 EST




On 1/20/22 05:28, Andy Shevchenko wrote:
> On Thu, Jan 20, 2022 at 1:08 AM Terry Bowman <terry.bowman@xxxxxxx> wrote:
>>
>> AMD processors include registers capable of selecting between 2 SMBus
>> ports. Port selection is made during each user access by writing to
>> FCH::PM::DECODEEN[smbus0sel]. Change the driver to use MMIO during
>> SMBus port selection because cd6h/cd7h port I/O is not available on
>> later AMD processors.
>
> ...
>
>> }
>> +
>> /*
>
> Stray change.
>
>

Hi Andy,

Looking at this closer I find the added line separates the closing
function brace from the next function's comment header. Are you sure I
need to remove this line?

Regards,
Terry