Re: [PATCH v11 4/5] clocksource/drivers: Add a goldfish-timer clocksource

From: kernel test robot
Date: Fri Jan 21 2022 - 07:24:59 EST


Hi Laurent,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/timers/core]
[also build test ERROR on linux/master linus/master next-20220121]
[cannot apply to geert-m68k/for-next v5.16]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Laurent-Vivier/m68k-Add-Virtual-M68k-Machine/20220120-160832
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 35e13e9da9afbce13c1d36465504ece4e65f24fe
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220121/202201212032.qL41ty3V-lkp@xxxxxxxxx/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ea1170b472532011ab0c8208b6414a36810f45ab
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Laurent-Vivier/m68k-Add-Virtual-M68k-Machine/20220120-160832
git checkout ea1170b472532011ab0c8208b6414a36810f45ab
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/clocksource/timer-goldfish.c: In function 'goldfish_timer_read':
>> drivers/clocksource/timer-goldfish.c:52:20: error: implicit declaration of function 'gf_ioread32'; did you mean 'ioread32'? [-Werror=implicit-function-declaration]
52 | time_low = gf_ioread32(base + TIMER_TIME_LOW);
| ^~~~~~~~~~~
| ioread32
drivers/clocksource/timer-goldfish.c: In function 'goldfish_timer_set_oneshot':
>> drivers/clocksource/timer-goldfish.c:65:9: error: implicit declaration of function 'gf_iowrite32'; did you mean 'iowrite32'? [-Werror=implicit-function-declaration]
65 | gf_iowrite32(0, base + TIMER_ALARM_HIGH);
| ^~~~~~~~~~~~
| iowrite32
cc1: some warnings being treated as errors


vim +52 drivers/clocksource/timer-goldfish.c

40
41 static u64 goldfish_timer_read(struct clocksource *cs)
42 {
43 struct goldfish_timer *timerdrv = cs_to_gf(cs);
44 void __iomem *base = timerdrv->base;
45 u32 time_low, time_high;
46 u64 ticks;
47
48 /*
49 * time_low: get low bits of current time and update time_high
50 * time_high: get high bits of time at last time_low read
51 */
> 52 time_low = gf_ioread32(base + TIMER_TIME_LOW);
53 time_high = gf_ioread32(base + TIMER_TIME_HIGH);
54
55 ticks = ((u64)time_high << 32) | time_low;
56
57 return ticks;
58 }
59
60 static int goldfish_timer_set_oneshot(struct clock_event_device *evt)
61 {
62 struct goldfish_timer *timerdrv = ced_to_gf(evt);
63 void __iomem *base = timerdrv->base;
64
> 65 gf_iowrite32(0, base + TIMER_ALARM_HIGH);
66 gf_iowrite32(0, base + TIMER_ALARM_LOW);
67 gf_iowrite32(1, base + TIMER_IRQ_ENABLED);
68
69 return 0;
70 }
71

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx