Re: [PATCH v3 1/3] of: base: make small of_parse_phandle() variants static inline

From: Rob Herring
Date: Thu Jan 20 2022 - 12:30:57 EST


On Tue, 18 Jan 2022 18:35:02 +0100, Michael Walle wrote:
> Make all the smaller variants of the of_parse_phandle() static inline.
> This also let us remove the empty function stubs if CONFIG_OF is not
> defined.
>
> Suggested-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Michael Walle <michael@xxxxxxxx>
> ---
> changes since v3:
> - rebased due to now signed index parameter
>
> changes since v2:
> - new patch
>
> drivers/of/base.c | 128 ++----------------------------------
> include/linux/of.h | 157 +++++++++++++++++++++++++++++++++++++--------
> 2 files changed, 135 insertions(+), 150 deletions(-)
>

I moved the index < 0 checks into __of_parse_phandle_with_args
and applied, thanks!