Re: [PATCH v3 3/9] brcmfmac: firmware: Do not crash on a NULL board_type

From: Arend van Spriel
Date: Thu Jan 20 2022 - 08:37:52 EST


On 1/20/2022 2:24 PM, Dmitry Osipenko wrote:
20.01.2022 16:23, Dmitry Osipenko пишет:
20.01.2022 11:29, Arend van Spriel пишет:
On 1/19/2022 11:02 PM, Dmitry Osipenko wrote:
17.01.2022 17:29, Hector Martin пишет:
This unbreaks support for USB devices, which do not have a board_type
to create an alt_path out of and thus were running into a NULL
dereference.

Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware
binaries")
Signed-off-by: Hector Martin <marcan@xxxxxxxxx>

Technically, all patches that are intended to be included into next
stable kernel update require the "Cc: stable@xxxxxxxxxxxxxxx" tag.

Being the nit picker that I am I would say it is recommended to safe
yourself extra work, not required, for the reason you give below.

Will be nice if stable tag could officially become a recommendation,
implying the stable tag. It's a requirement today, at least Greg KH
always demands to add it :)

*implying the stable tag if "fixes" tag presents.

I was a little confused reading your previous email in this thread. This makes a lot more sense :-p

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature