Re: [PATCH v4 60/66] mm/oom_kill: Use maple tree iterators instead of vma linked list

From: Vlastimil Babka
Date: Thu Jan 20 2022 - 07:43:38 EST


On 12/1/21 15:30, Liam Howlett wrote:
> From: "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>
>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

Could be VMA_ITERATOR?

> ---
> mm/oom_kill.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 1ddabefcfb5a..1694b30eb46c 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -516,6 +516,7 @@ bool __oom_reap_task_mm(struct mm_struct *mm)
> {
> struct vm_area_struct *vma;
> bool ret = true;
> + MA_STATE(mas, &mm->mm_mt, 0, 0);
>
> /*
> * Tell all users of get_user/copy_from_user etc... that the content
> @@ -525,7 +526,7 @@ bool __oom_reap_task_mm(struct mm_struct *mm)
> */
> set_bit(MMF_UNSTABLE, &mm->flags);
>
> - for (vma = mm->mmap ; vma; vma = vma->vm_next) {
> + mas_for_each(&mas, vma, ULONG_MAX) {
> if (!can_madv_lru_vma(vma))
> continue;
>