Re: [PATCH 2/7] arm64: dts: ls1028a: move Mali DP500 node into /soc

From: Michael Walle
Date: Thu Jan 20 2022 - 03:17:44 EST


Am 2022-01-20 09:06, schrieb Leo Li:
-----Original Message-----
From: Michael Walle <michael@xxxxxxxx>
Sent: Tuesday, August 31, 2021 9:40 PM
To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
kernel@xxxxxxxxxxxxxxx
Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Rob
Herring <robh+dt@xxxxxxxxxx>; Vladimir Oltean <vladimir.oltean@xxxxxxx>;
Michael Walle <michael@xxxxxxxx>
Subject: [PATCH 2/7] arm64: dts: ls1028a: move Mali DP500 node into /soc

Move it inside the /soc subnode because it is part of the CCSR space.

I just noticed that the dp0_out label has been changed to dpi0_out
besides the move. Is this an intentional change or a typo? If
intentional we probably should mention it, otherwise we should change
it back as it is breaking build for off-tree patch that uses the
label.

It's intentional, because dp0_out might sound like displayport. And
from what I've found the output is a display pixel interface, hence dpi.

I agree, that this should have been two patches, must have slipped.
But this series was merged months ago, so we can't change anything
anymore.

Besides, given the fact that there is no support for the DisplayPort
PHY in upstream (yet, I'm working on that), I doubt there are any
out-of-tree device trees, which don't use the proprietary NXP
driver.

Also, if there is an out-of-tree device tree, it should be easy
enough for NXP to change that :)

-michael