Re: [PATCH] devtmpfs: drop redundant fs parameters from internal fs

From: Christoph Hellwig
Date: Thu Jan 20 2022 - 02:29:44 EST


On Wed, Jan 19, 2022 at 11:02:48PM +0100, Anthony Iliopoulos wrote:
> The internal_fs_type is mounted via vfs_kernel_mount() and is never
> registered as a filesystem, thus specifying the parameters is redundant
> as those params will not be validated by fs_validate_description().
>
> Both {shmem,ramfs}_fs_parameters are anyway validated when those
> respective filesystems are first registered, so there is no reason to
> pass them to devtmpfs too, drop them.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>