RE: [PATCH v2 14/16] arm64: dts: fsd: Add initial device tree support

[Alim Akhtar]

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx]
>Sent: Wednesday, January 19, 2022 12:15 AM
>To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; linux-arm-
>kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Cc: soc@xxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
>olof@xxxxxxxxx; arnd@xxxxxxxx; linus.walleij@xxxxxxxxxx;
>catalin.marinas@xxxxxxx; robh+dt@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx;
>linux-samsung-soc@xxxxxxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; linux-
>fsd@xxxxxxxxx; Arjun K V <arjun.kv@xxxxxxxxxxx>; Aswani Reddy
><aswani.reddy@xxxxxxxxxxx>; Ajay Kumar <ajaykumar.rs@xxxxxxxxxxx>;
>Sriranjani P <sriranjani.p@xxxxxxxxxxx>; Chandrasekar R
><rcsekar@xxxxxxxxxxx>; Shashank Prashar <s.prashar@xxxxxxxxxxx>
>Subject: Re: [PATCH v2 14/16] arm64: dts: fsd: Add initial device tree support
>
>On 18/01/2022 15:48, Alim Akhtar wrote:
>> Add initial device tree support for "Full Self-Driving" (FSD) SoC This
>> SoC contain three clusters of four cortex-a72 CPUs and various
>> peripheral IPs.
>>
>> Cc: linux-fsd@xxxxxxxxx
>> Signed-off-by: Arjun K V <arjun.kv@xxxxxxxxxxx>
>> Signed-off-by: Aswani Reddy <aswani.reddy@xxxxxxxxxxx>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@xxxxxxxxxxx>
>> Signed-off-by: Sriranjani P <sriranjani.p@xxxxxxxxxxx>
>> Signed-off-by: Chandrasekar R <rcsekar@xxxxxxxxxxx>
>> Signed-off-by: Shashank Prashar <s.prashar@xxxxxxxxxxx>
>> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
>> ---
>>  MAINTAINERS                           |   8 +
>>  arch/arm64/Kconfig.platforms          |   7 +
>>  arch/arm64/boot/dts/Makefile          |   1 +
>>  arch/arm64/boot/dts/tesla/Makefile    |   3 +
>>  arch/arm64/boot/dts/tesla/fsd-evb.dts |  39 ++
>>  arch/arm64/boot/dts/tesla/fsd.dtsi    | 651
>++++++++++++++++++++++++++
>>  6 files changed, 709 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/tesla/Makefile
>>  create mode 100644 arch/arm64/boot/dts/tesla/fsd-evb.dts
>>  create mode 100644 arch/arm64/boot/dts/tesla/fsd.dtsi
>>
>
>I saw you dropped the MCT timer from DTSI. I wonder why?
>
I dropped it intentionally, as you had a comment on MCT driver changes, so will send later along with MCT driver fix.

>Not very happy with FSD naming (as discussed before), but board compatible
>looks reasonable. Code looks good to me:
>Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>
Thanks Krzysztof for all the reviews.

>Similarly to previous vendor-prefix patch, please let me know if it's expected
>me to take it. I assume no. :)
>
I am expecting this will go via your tree, but I am ok either ways. May be you and arm-soc maintainers (Arnd/Olof) can take the call here.

>Best regards,
>Krzysztof