Re: [PATCH] MAINTAINERS: add missing "security/integrity" directory

From: Petr Vorel
Date: Wed Jan 19 2022 - 02:35:46 EST


Hi Mimi,

LGTM.
Reviewed-by: Petr Vorel <pvorel@xxxxxxx>

Few comments below.

> Update the IMA and EVM records to include the "security/integrity"
> directory.

> Signed-off-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5250298d2817..a9973d0991e3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7181,6 +7181,7 @@ M: Mimi Zohar <zohar@xxxxxxxxxxxxx>
> L: linux-integrity@xxxxxxxxxxxxxxx
> S: Supported
Aren't you a maintainer? How about
S: Maintained

> F: security/integrity/evm/
> +F: security/integrity
I'd add trailing slash (i.e. security/integrity/)

How about adding git tree to EVM?

> EXTENSIBLE FIRMWARE INTERFACE (EFI)
> M: Ard Biesheuvel <ardb@xxxxxxxxxx>
> @@ -9419,6 +9420,7 @@ L: linux-integrity@xxxxxxxxxxxxxxx
> S: Supported
and here

> T: git git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git
> F: security/integrity/ima/
> +F: security/integrity
and here

> INTEL 810/815 FRAMEBUFFER DRIVER
> M: Antonino Daplas <adaplas@xxxxxxxxx>

Kind regards,
Petr