Re: [PATCH] ipv4: Namespaceify min_adv_mss sysctl knob

From: Jakub Kicinski
Date: Tue Jan 18 2022 - 21:23:26 EST


On Wed, 19 Jan 2022 02:04:27 +0000 xu xin wrote:
> > > From: xu xin <xu.xin16@xxxxxxxxxx>
> > >
> > > Different netns have different requirement on the setting of min_adv_mss
> > > sysctl that the advertised MSS will be never lower than. The sysctl
> > > min_adv_mss can indirectly affects the segmentation efficiency of TCP.
> > >
> > > So enable min_adv_mss to be visible and configurable inside the netns.
> > >
> > > Signed-off-by: CGEL ZTE <cgel.zte@xxxxxxxxx>
> >
> > CGEL ZTE, whatever it is, is most definitely not a person so it can't
> > sign off patches. Please stop adding the CGEL task, you can tell us
> > what it stands for it you want us to suggest an alternative way of
> > marking.
>
> CGEL ZTE is a team(or project) focusing on Embedded Linux System. With
> the support of the team, I can devote myself to the development and
> maintenance of the kernel and related patch work.
>
> I'm not sure how to mark it here accurately. I am willing to hear your
> suggestions.

What I've seen done in the past is adding the name of your team/project
after your name, in parenthesis, so it'd be something like:

Signed-off-by: xu xin (CGEL ZTE) <xu.xin16@xxxxxxxxxx>

Similarly for your other colleagues, for example:

Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@xxxxxxxxxx>

Some Intel, Oracle and VMware employees follow a similar pattern.