Re: [PATCH 4/9] remoteproc: imx_rproc: ignore create mem entry for resource table

From: Mathieu Poirier
Date: Tue Jan 18 2022 - 13:47:26 EST


On Tue, Jan 11, 2022 at 11:33:28AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>

The "ignore" in the title should have a capital 'I'.

> resource table will not be used for memory allocation, no need to create

s/resource/Resource

> rproc mem entry.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> drivers/remoteproc/imx_rproc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 75fde16f80a4..7b2578177ea8 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> if (!strcmp(it.node->name, "vdev0buffer"))
> continue;
>
> + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> + continue;
> +

This is a bug fix that should be in a separate patch with a "Fixes:" tag.

> rmem = of_reserved_mem_lookup(it.node);
> if (!rmem) {
> dev_err(priv->dev, "unable to acquire memory-region\n");
> --
> 2.25.1
>