Re: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable

[Jakub Kicinski]

On Tue, 18 Jan 2022 07:19:04 -0800 Richard Cochran wrote:
> On Tue, Jan 18, 2022 at 07:54:38AM +0000, cgel.zte@xxxxxxxxx wrote:
> > From: Minghao Chi <chi.minghao@xxxxxxxxxx>
> > 
> > Return value from phy_read() directly instead
> > of taking this in another redundant variable.  
> 
> NAK this is purely cosmetic and not clearly better WRT CodingStyle.
>  
> > Reported-by: Zeal Robot <zealci@xxxxxxxxxx>  
> 
> Please make your robot less zealous or filter its results before
> posting.

Plus what does it mean that the bot has signed this off?

> > Signed-off-by: CGEL ZTE <cgel.zte@xxxxxxxxx>

> This is the second time I told you.  It isn't wise to ignore feedback,
> and it is also rude.

Same, you don't reply to emails and keep making the same mistakes.

I asked you to realign the continuation lines in:
https://lore.kernel.org/all/20220112083942.391fd0d7@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
And without replying you just posted:
https://lore.kernel.org/all/20220118075159.925542-1-chi.minghao@xxxxxxxxxx/