Re: Modules updates for v5.17-rc1

From: Luis Chamberlain
Date: Tue Jan 18 2022 - 11:17:19 EST


On Mon, Jan 17, 2022 at 07:38:25AM +0200, Linus Torvalds wrote:
> On Sat, Jan 15, 2022 at 2:20 AM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote:
> >
> > Although this change was only merged on January 11th, the patches have
> > been being reviewed since early december. There was at least one fix
> > already found for it and merged.
>
> Grr..
>
> And that's exactly why it matters not about "being reviewed", but when
> they were in linux-next etc.
>
> I've pulled this, but consider this a complaint. Things should not be
> "reviewed" before the merge window. They should be ready and merged
> and have actually seen some testing.
>
> Review is good. But nothing beats actually being out there and
> actually seeing real-life testing (of course, linux-next probably
> mostly gets build-testing, but what testing it gets is still better
> than not being there).

Understood, that gives me a better ballpark idea of when to defer
things for a next release. Thanks for the feedback.

Luis