Re: [PATCH] drm/virtio: Ensure that objs is not NULL in virtio_gpu_array_put_free()

From: Gerd Hoffmann
Date: Tue Jan 18 2022 - 01:56:37 EST


On Mon, Dec 13, 2021 at 07:31:22PM +0100, Roberto Sassu wrote:
> If virtio_gpu_object_shmem_init() fails (e.g. due to fault injection, as it
> happened in the bug report by syzbot), virtio_gpu_array_put_free() could be
> called with objs equal to NULL.
>
> Ensure that objs is not NULL in virtio_gpu_array_put_free(), or otherwise
> return from the function.
>
> Cc: stable@xxxxxxxxxxxxxxx # 5.13.x
> Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
> Reported-by: syzbot+e9072e90624a31dfa85f@xxxxxxxxxxxxxxxxxxxxxxxxx
> Fixes: 377f8331d0565 ("drm/virtio: fix possible leak/unlock virtio_gpu_object_array")

Pushed to drm-misc-next.

thanks,
Gerd