Re: [PATCH 02/12] filemap: Use folio_put_refs() in filemap_free_folio()

From: Matthew Wilcox
Date: Mon Jan 17 2022 - 11:11:54 EST


On Mon, Jan 17, 2022 at 06:56:41PM +0300, Kirill A. Shutemov wrote:
> On Sun, Jan 16, 2022 at 12:18:12PM +0000, Matthew Wilcox (Oracle) wrote:
> > + if (folio_test_large(folio) && !folio_test_hugetlb(folio))
> > + refs = folio_nr_pages(folio);
>
> Isn't folio_test_large() check redundant? folio_nr_pages() would return 1
> for non-large folio, wouldn't it?

I'm trying to avoid the function call for !hugetlb pages.