Re: [PATCH] mtd: rawnand: protect access to rawnand devices while in suspend

From: Boris Brezillon
Date: Mon Jan 17 2022 - 02:54:56 EST


On Mon, 17 Jan 2022 08:43:39 +0100
Sean Nyekjaer <sean@xxxxxxxxxx> wrote:

> On Mon, Dec 20, 2021 at 02:00:15PM +0100, Sean Nyekjaer wrote:
> > Prevent rawnend access while in a suspended state.
> >
> > Commit 013e6292aaf5 ("mtd: rawnand: Simplify the locking") allows the
> > rawnand layer to return errors rather than waiting in a blocking wait.
> >
> > Tested on a iMX6ULL.
> >
> > Fixes: 013e6292aaf5 ("mtd: rawnand: Simplify the locking")
> > Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
> > ---
>
> Hi Boris and Miquel,
>
> I know the kernel test robot is complaining a bit about uninitialized
> values.
> But is this OK? If I fix the unitialized values?

With the 'uninitialized ret' issue fixed, it looks good to me:

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>

But you probably want to add a Cc:stable tag.