RE: [PATCH v16 2/4] dmaengine: tegra: Add tegra gpcdma driver

From: Akhil R
Date: Mon Jan 17 2022 - 02:02:14 EST


> 10.01.2022 19:05, Akhil R пишет:
> > +static int tegra_dma_terminate_all(struct dma_chan *dc)
> > +{
> > + struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
> > + unsigned long flags;
> > + LIST_HEAD(head);
> > + int err;
> > +
> > + if (tdc->dma_desc) {
>
> Needs locking protection against racing with the interrupt handler.
tegra_dma_stop_client() waits for the in-flight transfer
to complete and prevents any additional transfer to start.
Wouldn't it manage the race? Do you see any potential issue there?

Thanks,
Akhil

--
nvpublic