Re: [PATCH 2/7] random: cleanup integer types

From: Dominik Brodowski
Date: Sun Jan 16 2022 - 08:45:35 EST


Am Thu, Jan 13, 2022 at 04:44:08PM +0100 schrieb Jason A. Donenfeld:
> Rather than using the userspace type, __uXX, switch to using uXX. And
> rather than using variously chosen `char *` or `unsigned char *`, use
> `u8 *` uniformly for things that aren't strings, in the case where we
> are doing byte-by-byte traversal.
>
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>

> - unsigned short reg_idx;
> - unsigned char count;
> + u16 reg_idx;
> + u8 count;

As you do not change other unsigned shorts to u16, and that change is
not explained in the changelog, please defer that to a separate patch.
Otherwise, feel free to add:

Reviewed-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>

Thanks,
Dominik