Re: [PATCH v2 3/3] Documentation:ABI:testing:admv1014: add ABI docs

From: Jonathan Cameron
Date: Sun Jan 16 2022 - 07:54:45 EST


On Mon, 10 Jan 2022 17:13:50 +0200
Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> wrote:

> Add documentation for the use of the Digital Attenuator gain.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
Hi Antoniu,

Looks good to me though I'm keen to get other people's opinions as
it is a little unusual. So even if rest of the set is fine I'll
leave this on list for a little longer. (I'm reviewing backwards through
your series as makes more sense to me that way ;)

Thanks,

Jonathan

> ---
> .../testing/sysfs-bus-iio-frequency-admv1014 | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014 b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
> new file mode 100644
> index 000000000000..5bcd96d77f45
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
> @@ -0,0 +1,23 @@
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_coarse
> +KernelVersion:
> +Contact: linux-iio@xxxxxxxxxxxxxxx
> +Description:
> + Read/write value for the digital attenuator gain (IF_I) with coarse steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_coarse
> +KernelVersion:
> +Contact: linux-iio@xxxxxxxxxxxxxxx
> +Description:
> + Read/write value for the digital attenuator gain (IF_Q) with coarse steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_fine
> +KernelVersion:
> +Contact: linux-iio@xxxxxxxxxxxxxxx
> +Description:
> + Read/write value for the digital attenuator gain (IF_I) with fine steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_fine
> +KernelVersion:
> +Contact: linux-iio@xxxxxxxxxxxxxxx
> +Description:
> + Read/write value for the digital attenuator gain (IF_Q) with fine steps.