Re: [PATCH] pinctrl: qcom: Return -EINVAL for setting affinity if no IRQ parent

From: Linus Walleij
Date: Sun Jan 16 2022 - 07:03:02 EST


On Thu, Jan 13, 2022 at 5:26 PM Manivannan Sadhasivam
<manivannan.sadhasivam@xxxxxxxxxx> wrote:

> The MSM GPIO IRQ controller relies on the parent IRQ controller to set the
> CPU affinity for the IRQ. And this is only valid if there is any wakeup
> parent available and defined in DT.
>
> For the case of no parent IRQ controller defined in DT,
> msm_gpio_irq_set_affinity() and msm_gpio_irq_set_vcpu_affinity() should
> return -EINVAL instead of 0 as the affinity can't be set.
>
> Otherwise, below warning will be printed by genirq:
>
> genirq: irq_chip msmgpio did not update eff. affinity mask of irq 70
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

Patch applied for v5.18!

Yours,
Linus Walleij