Re: [PATCH] drm/amd/pm: Replace one-element array with flexible-array member

From: Alex Deucher
Date: Fri Jan 14 2022 - 17:14:50 EST


Applied. Thanks!

On Fri, Jan 14, 2022 at 4:20 AM <cgel.zte@xxxxxxxxx> wrote:
>
> From: Changcheng Deng <deng.changcheng@xxxxxxxxxx>
>
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use "flexible array members" for these cases. The older
> style of one-element or zero-length arrays should no longer be used.
> Reference:
> https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Changcheng Deng <deng.changcheng@xxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/pm/powerplay/inc/smu_ucode_xfer_cz.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/smu_ucode_xfer_cz.h b/drivers/gpu/drm/amd/pm/powerplay/inc/smu_ucode_xfer_cz.h
> index eb0f79f9c876..701aae598b58 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/inc/smu_ucode_xfer_cz.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/inc/smu_ucode_xfer_cz.h
> @@ -121,7 +121,7 @@ typedef struct SMU_Task SMU_Task;
>
> struct TOC {
> uint8_t JobList[NUM_JOBLIST_ENTRIES];
> - SMU_Task tasks[1];
> + SMU_Task tasks[];
> };
>
> // META DATA COMMAND Definitions
> --
> 2.25.1
>