Re: [PATCH 2/5] platform: surface: Propagate ACPI Dependency

From: Felipe Balbi
Date: Fri Jan 14 2022 - 01:21:51 EST



Hi,

Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:
> Hi Jarrett,
>
> On Mon, Dec 6, 2021 at 4:03 PM Jarrett Schultz <jaschultzms@xxxxxxxxx> wrote:
>> Since the Surface XBL Driver does not depend on ACPI, the
>> platform/surface directory as a whole no longer depends on ACPI. With
>> respect to this, the ACPI dependency is moved into each config that depends
>> on ACPI individually.
>>
>> Signed-off-by: Jarrett Schultz <jaschultz@xxxxxxxxxxxxx>
>
> Thanks for your patch, which is now commit 272479928172edf0 ("platform:
> surface: Propagate ACPI Dependency").
>
>> --- a/drivers/platform/surface/Kconfig
>> +++ b/drivers/platform/surface/Kconfig
>> @@ -5,7 +5,6 @@
>>
>> menuconfig SURFACE_PLATFORMS
>> bool "Microsoft Surface Platform-Specific Device Drivers"
>> - depends on ACPI
>> default y
>> help
>> Say Y here to get to see options for platform-specific device drivers
>
> Without any dependency, all users configuring a kernel are now asked
> about this. Is there any other platform dependency that can be used
> instead?

there's probably no symbol that would be true for x86 and arm64 while
being false for everything else. Any ideas?

In any case, what's the problem of being asked about a new symbol? That
happens all the time whenever new drivers are merged, right?

--
balbi