Re: [PATCH v6 07/10] hda: cs35l41: Add support for CS35L41 in HDA systems

From: Andy Shevchenko
Date: Thu Jan 13 2022 - 13:21:34 EST


On Thu, Jan 13, 2022 at 8:13 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Jan 13, 2022 at 6:53 PM Lucas tanure
> <tanureal@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > On 1/6/22 12:29, Andy Shevchenko wrote:
> > > On Fri, Dec 17, 2021 at 5:45 PM Lucas Tanure
> > > <tanureal@xxxxxxxxxxxxxxxxxxxxx> wrote:

...

> > >> + * Device CLSA0100 doesn't have _DSD so a gpiod_get by the label reset won't work.
> > >
> > > So, you need to add mapping tables and switch to regular APIs, tell
> > > me, why it won't work.

> > The part about how the driver access the ACPI table is going to be
> > improved later if possible.
> > The laptop has already shipped and doesn't have a _DSD node, so the
> > driver needs to read the reset GPIO from a hard coded index inside a
> > node that contains more than one cs35l41.
>
> We have a lot of cases like this, hint: `git grep -n -w
> devm_acpi_dev_add_driver_gpios`.

It's all described here: Documentation/firmware-guide/acpi/gpio-properties.rst

--
With Best Regards,
Andy Shevchenko