Re: [PATCH] pps: clients: gpio: Propagate return value from pps_gpio_probe

From: Rodolfo Giometti
Date: Thu Jan 13 2022 - 03:25:08 EST


On 12/01/22 22:07, Andy Shevchenko wrote:
> On Wed, Jan 12, 2022 at 02:52:14PM -0600, Robert Hancock wrote:
>> If the pps-gpio driver was probed prior to the GPIO device it uses, the
>> devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe
>> replaced that error code with -EINVAL, causing the pps-gpio probe to
>> fail and not be retried later. Propagate the error return value so that
>> deferred probe works properly.
>
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Acked-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
>
>> Fixes: 161520451dfa (pps: new client driver using GPIO)
>> Signed-off-by: Robert Hancock <robert.hancock@xxxxxxxxxx>
>> ---
>> drivers/pps/clients/pps-gpio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
>> index 35799e6401c9..2f4b11b4dfcd 100644
>> --- a/drivers/pps/clients/pps-gpio.c
>> +++ b/drivers/pps/clients/pps-gpio.c
>> @@ -169,7 +169,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
>> /* GPIO setup */
>> ret = pps_gpio_setup(dev);
>> if (ret)
>> - return -EINVAL;
>> + return ret;
>>
>> /* IRQ setup */
>> ret = gpiod_to_irq(data->gpio_pin);
>> --
>> 2.31.1
>>
>


--
GNU/Linux Solutions e-mail: giometti@xxxxxxxxxxxx
Linux Device Driver giometti@xxxxxxxx
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti