Re: [PATCH 0/4] workqueue: cleanups for schedule callbacks part2

From: Tejun Heo
Date: Wed Jan 12 2022 - 12:47:33 EST


On Thu, Dec 23, 2021 at 08:31:36PM +0800, Lai Jiangshan wrote:
> From: Lai Jiangshan <laijs@xxxxxxxxxxxxxxxxx>
>
> The commit 6d25be5782e4 ("sched/core, workqueues: Distangle worker
> accounting from rq lock") changed the schedule callbacks for workqueue.
>
> It simplified the connection between scheduler and workqueue. But it
> caused some code useless and some comments outdated in workqueue which
> needs to be cleaned up.
>
> Patch1-3 are the cleanups based on the fact that 6d25be5782e4 changed
> to use pool lock in wq_worker_sleeping().
>
> Patch4 is based on the fact that schedule callbacks were changed to be
> only called from schedule() which means all modification to nr_running
> is on local CPU when the worker is concurrent managed.

Applied 1-4 to wq/for-5.18. I updated the comment on the last patch.

Thanks.

--
tejun