Re: [PATCH v2] lib/crypto: add prompts back to crypto libraries

From: Ard Biesheuvel
Date: Wed Jan 12 2022 - 09:13:46 EST


On Wed, 12 Jan 2022 at 15:12, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
>
> On Wed, Jan 12, 2022 at 3:08 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote:
> >
> > On Wed, 12 Jan 2022 at 15:08, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
> > >
> > > On Wed, Jan 12, 2022 at 3:06 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote:
> > > >
> > > > On Wed, 12 Jan 2022 at 15:05, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
> > > > >
> > > > > This commit also needs this snippet:
> > > > >
> > > >
> > > > Why?
> > >
> > > So that the menu of crypto library options is inside of the library
> > > menu. Otherwise this will appear inside of the _root_ menu, which
> > > isn't what we want.
> >
> > Why not? I think that's fine.
>
> It's really not appropriate there. Look:
>
> - Justin vanilla: https://i.imgur.com/14UBpML.png
> - Justin + Jason: https://i.imgur.com/lDfZnma.png
>
> We really don't want another top level menu. We're not that important.
> Rather, crypto libraries are but one ordinary subset of ordinary
> libraries, just like how the build system does it too.

I disagree. The root menu is a jumble of things already, and having
this one at the root is really not a problem.