Re: [PATCH v6 8/9] mm: multigenerational lru: user interface

From: Michal Hocko
Date: Wed Jan 12 2022 - 05:32:01 EST


On Wed 12-01-22 01:35:52, Yu Zhao wrote:
[...]
> But I saw people not following this practice, and I'm also tempted to
> do so. Can anybody remind me whether it's considered a bad practice to
> have code changes and Kconfig changes in the same patch?

If you want to have the patch series bisectable then it is preferable to
add kconfig options early so that the code is enabled in the respective
steps. Sometimes that can be impractical though (e.g. when the feature is
incomplete at that stage).
--
Michal Hocko
SUSE Labs