Re: [PATCH v1 1/1] vsprintf: Fix potential unaligned access

From: Andy Shevchenko
Date: Tue Jan 11 2022 - 05:11:54 EST


On Tue, Jan 11, 2022 at 12:12:46AM +0200, Sakari Ailus wrote:
> On Mon, Jan 10, 2022 at 10:50:49PM +0200, Andy Shevchenko wrote:
> > The %p4cc specifier in some cases might get an unaligned pointer.
> > Due to this we need to make copy to local variable once to avoid
> > potential crashes on some architectures due to improper access.
>
> I guess this problem exists virtually everywhere where pointers are being
> handled: the pointer could be unaligned.

True. And my patch improves the situation.
See, for example, 0f70fe605fad ("hexdump: fix for non-aligned buffers").

> Does this even address the false
> positive compiler warning?

First of all, the warning is real and legit, it's not false positive.
Second, no, this is another side of the fix.

--
With Best Regards,
Andy Shevchenko