Re: [PATCH v1 2/2] drm/sprd: fix potential NULL dereference

From: Javier Martinez Canillas
Date: Tue Jan 11 2022 - 04:18:43 EST


On 12/24/21 15:12, Kevin Tang wrote:
> platform_get_resource() may fail and return NULL, so check it's value
> before using it.
>
> 'drm' could be null in sprd_drm_shutdown, and drm_warn maybe dereference
> it, remove this warning log.
>

I would split this second change in a separate patch and just keep this
one about checking the platform_get_resource() return value.

If you do that, feel free to add:

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat