Re: [PATCH v4 04/48] perf stat: Switch aggregation to use for_each loop

From: John Garry
Date: Mon Jan 10 2022 - 13:51:16 EST


On 05/01/2022 06:13, Ian Rogers wrote:
+ cpus = evsel__cpus(evsel);
+ perf_cpu_map__for_each_cpu(cpu, idx, cpus) {

It seems a common pattern to evaluate cpus and use in perf_cpu_map__for_each_cpu() - is it possible to make a macro to accept evsel and create cpus, like perf_evsel__for_each_cpu()?

+ if (cpu_map__compare_aggr_cpu_id(config->aggr_get_id(config, cpus, idx),
+ id))
+ return cpu;
}
return 0;