Re: [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu.

From: John Garry
Date: Mon Jan 10 2022 - 12:10:28 EST


On 05/01/2022 06:13, Ian Rogers wrote:
+struct aggr_cpu_id cpu_map__get_socket(struct perf_cpu_map *map, int idx,
+ void *data)
+{
+ if (idx < 0 || idx > map->nr)
+ return cpu_map__empty_aggr_cpu_id();
+
+ return cpu_map__get_socket_aggr_by_cpu(map->map[idx], data);
+}
+


This is later deleted in the series. Can the series be reworked so that we don't add stuff and then later delete it? One reason for that approach is that we don't spend time reviewing something which will be deleted, especially in such a big series...

If it really makes sense to do it this way then fine.

Thanks,
John