Re: [PATCH] KVM: Fix OOM vulnerability caused by continuously creating devices

From: Sean Christopherson
Date: Mon Jan 10 2022 - 11:12:24 EST


On Sun, Jan 09, 2022, Yi Wang wrote:
> From: ZhaoQiang <zhao.qiang11@xxxxxxxxxx>
>
> When processing the ioctl request for creating a device in the
> kvm_vm_ioctl()function,the branch did not reclaim the successfully
> created device,which caused memory leak.

It's not a memory leak, kvm_destroy_vm() => kvm_destroy_devices() will free all
devices. anon_inode_getfd() installes the devices fd, so the device's fd and its
reference to KVM will be put when the process exits. Am I missing something?