RE: [PATCH v6 07/21] x86/fpu: Provide fpu_enable_guest_xfd_features() for KVM

From: Tian, Kevin
Date: Mon Jan 10 2022 - 00:26:09 EST


Hi, Paolo,

> From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Sent: Saturday, January 8, 2022 2:55 AM
>
> +/*
> + * fpu_enable_guest_xfd_features - Check xfeatures against guest perm
> and enable
> + * @guest_fpu: Pointer to the guest FPU container
> + * @xfeatures: Features requested by guest CPUID
> + *
> + * Enable all dynamic xfeatures according to guest perm and requested
> CPUID.
> + *
> + * Return: 0 on success, error code otherwise
> + */

Just a NIT. This function itself has nothing to do with guest CPUID
which is a caller-side policy. It simply enable xfeatures per request.

Thanks
Kevin