Re: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap
From: Jiasheng Jiang
Date: Fri Jan 07 2022 - 22:56:30 EST
On Sat, Jan 08, 2022 at 10:53:42PM +0800, Damien Le Moal wrote:
>> Cc: stable@xxxxxxxxxxxxxxx#5.10
>
> Please keep the space before the #
>
> Cc: stable@xxxxxxxxxxxxxxx #5.10
Actually, I added the space before, but the when I use the tool
'scripts/checkpatch.pl' to check my format, it told me a warning
that it should not have space.
The warning is as follow:
WARNING: email address 'stable@xxxxxxxxxxxxxxx #5.10' might be
better as 'stable@xxxxxxxxxxxxxxx#5.10'
So I have no idea what is correct.
Is the tool outdated?
If so, I will correct my cc and please update the tool.
> As commented before, what exactly was corrected ? That is what needs to be
> mentioned here. In any case, I fail to see what code change you added between v2
> and v3. The code changes are identical in the 2 versions.
Thanks, I will make the changelog more clear.
In fact, in the v2 I was careless to write '!!alt_base'.
So I removed the redundant '!' in v3.
Please tell me the right cc format, and then I will submit a new v3,
without the problems above.
Sincerely thanks,
Jiang