Re: [PATCH -next] ieee802154: atusb: move to new USB API

[Stefan Schmidt]

Hello.

On 05.01.22 21:58, Pavel Skripkin wrote:
> Hi Stefan,
>
> On 1/5/22 23:27, Stefan Schmidt wrote:
> > > +    ret = usb_control_msg_recv(usb_dev, 0, ATUSB_REG_READ, 
> > > ATUSB_REQ_FROM_DEV,
> > > +                   0, RG_PART_NUM, &atusb, 1, 1000, GFP_KERNEL);
> >
> > This needs to be written to &part_num and not &atusb.
>
> Oh, stupid copy-paste error :( Thanks for catching this!
>
> > Pretty nice for a first blind try without hardware. Thanks.
> >
> > Will let you know if I find anything else from testing.
>
> Ok, will wait for test results. Thank you for your time ;)

Testing went fine and showed no additional problems. I spotted one more 
thing in review though which I would like to see changed. See my reply 
to the patch itself.

regards
Stefan Schmidt