Re: [PATCH 4.14] phonet: refcount leak in pep_sock_accep

From: Greg KH
Date: Fri Jan 07 2022 - 06:24:13 EST


On Fri, Jan 07, 2022 at 02:53:32AM -0800, Aayush Agarwal wrote:
> From: Hangyu Hua <hbh25y@xxxxxxxxx>
>
> commit bcd0f9335332 ("phonet: refcount leak in pep_sock_accep")
> upstream.
>
> sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not
> invoked in subsequent failure branches(pep_accept_conn() != 0).
>
> Signed-off-by: Hangyu Hua <hbh25y@xxxxxxxxx>
> Link: https://lore.kernel.org/r/20211209082839.33985-1-hbh25y@xxxxxxxxx
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Aayush Agarwal <aayush.a.agarwal@xxxxxxxxxx>
> ---
> net/phonet/pep.c | 1 +
> 1 file changed, 1 insertion(+)

What about releases 5.15.y, 5.10.y, 5.4.y, and 4.19.y? Is this also
relevant for those trees?

thanks,

greg k-h