Re: [PATCH v5 0/4] clk: ralink: make system controller a reset provider

From: Stephen Boyd
Date: Thu Jan 06 2022 - 21:10:38 EST


Quoting Sergio Paracuellos (2021-12-13 04:00:17)
> Hi Stephen,
>
> On Sun, Nov 7, 2021 at 8:42 AM Sergio Paracuellos
> <sergio.paracuellos@xxxxxxxxx> wrote:
> >
> > Hi all,
> >
> > This patch series add minimal change to provide mt7621 resets properly
> > defining them in the 'mediatek,mt7621-sysc' node which is the system
> > controller of the SoC and is already providing clocks to the rest of
> > the world.
> >
> > There is shared architecture code for all ralink platforms in 'reset.c'
> > file located in 'arch/mips/ralink' but the correct thing to do to align
> > hardware with software seems to define and add related reset code to the
> > already mainlined clock driver.
> >
> > After this changes, we can get rid of the useless reset controller node
> > in the device tree and use system controller node instead where the property
> > '#reset-cells' has been added. Binding documentation for this nodeq has
> > been updated with the new property accordly.
> >
> > This series also provide a bindings include header where all related
> > reset bits for the MT7621 SoC are defined.
> >
> > Also, please take a look to this review [0] to understand better motivation

Is [0] a link?

> > for this series.
> >
> > Regarding the way of merging this:
> > - I'd like patches 1 and 4 which are related going through staging tree.
> > - The other two (patches 2 and 3) can perfectly go through the clock tree.
> >
> > Thanks in advance for your feedback.
> >
> > Changes in v5:
> > - Move platform driver init process into 'arch_initcall' to be sure the
> > rest of the world can get the resets available when needed (since PCIe
> > controller driver has been moved from staging into 'drivers/pci/controller'
> > is probed earlier and reset was not available so it was returning
> > -EPROBE_DEFER on firt try. Moving into 'arch_initcall' avoids the 'a bit
> > anoying' PCI first failed log trace.
>
> Gentle ping on this series.
>

It looks to largely be a reset controller patch series. Can you get
review from the reset maintainer?

RESET CONTROLLER FRAMEWORK
M: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
S: Maintained