Re: [PATCH v2 net] net/xfrm: IPsec tunnel mode fix inner_ipproto setting in sec_path

From: Saeed Mahameed
Date: Thu Jan 06 2022 - 19:48:52 EST


On Thu, Jan 06, 2022 at 10:32:23AM +0100, Steffen Klassert wrote:
On Mon, Jan 03, 2022 at 01:19:29PM +0200, Raed Salem wrote:
The inner_ipproto saves the inner IP protocol of the plain
text packet. This allows vendor's IPsec feature making offload
decision at skb's features_check and configuring hardware at
ndo_start_xmit, current code implenetation did not handle the
case where IPsec is used in tunnel mode.

Fix by handling the case when IPsec is used in tunnel mode by
reading the protocol of the plain text packet IP protocol.

Fixes: fa4535238fb5 ("net/xfrm: Add inner_ipproto into sec_path")
Signed-off-by: Raed Salem <raeds@xxxxxxxxxx>

Applied, thanks Raed!

hmm, there are two mlx5 patches that depend on this patch, I thought Raed
was planning to send them along with this.

Steffen, is it ok if I submit those two patches to you and so you would
send them all at once in your next net PR ?

Thanks,
Saeed.