Re: [PATCH v2 02/35] brcmfmac: pcie: Declare missing firmware files in pcie.c

[Hector Martin]

On 2022/01/06 18:56, Arend van Spriel wrote:
> On 1/4/2022 8:26 AM, Hector Martin wrote:
>> Move one of the declarations from sdio.c to pcie.c, since it makes no
>> sense in the former (SDIO support is optional), and add missing ones.
> 
> Actually, any bus is optional so each bus should indeed declare the 
> applicable firmware names/patterns.

Of course; I didn't mean *only* SDIO support is optional :)

>> +/* firmware config files */
>> +MODULE_FIRMWARE(BRCMF_FW_DEFAULT_PATH "brcmfmac*-pcie.txt");
> 
> what is this one for? Those would be covered by the specific 
> BRCMF_FW_DEF() macro instances, no?

The BRCMF_FW_DEF() macro only declares the .bin file; BRCMF_FW_CLM_DEF
declares that and the .clm_blob. Neither declare the NVRAM .txt.

-- 
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub