Re: [PATCH v7] lib/crypto: blake2s: include as built-in

[Ard Biesheuvel]

On Wed, 5 Jan 2022 at 22:53, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> On Tue, Jan 04, 2022 at 06:02:52PM +0100, Ard Biesheuvel wrote:
> > The only downside here is that the ARM/x86 accelerated shashes and the
> > generic shash now use the same core transform, right?
>
> I don't see how this is the case, given that crypto/blake2s_generic.c still uses
> blake2s_compress_generic(), not blake2s_compress().
>

Ah ok, I stand corrected then.

So what are your thoughts on this? Should we keep the shashes while
they have no users?